Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Component Governance alerts for botbuilder-js #4206

Closed
wants to merge 2 commits into from

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Apr 28, 2022

Fixes #4188

Description

Branch main has 6 code governance alerts with high severity or above on these components:

  • minimist 1.2.5 severity: critical
  • async 2.6.0 severity: high
  • async 1.5.2 severity: high
  • async 2.6.3 severity: high
  • async 3.2.0 severity: high
  • nconf 0.11.2 severity: high

This fixes all but minimist. That fix requires a new release of orchestrator-core. orchestrator-core development version 4.15.0-dev.20220422.8d959f7h contains the minimist fix now. It could be released as version 4.14.4.

Specific Changes

Bump nconf to 0.11.4.
Add async 3.2.3 and minimist 1.2.6 to resolutions.
Update dependency @microsoft/orchestrator-core to latest.
Drop an irrelevant package-lock.json file.
Update yarn.lock to match changes.
Add Component Detection to streaming E2E tests to replace injected CD.

@BruceHaley BruceHaley requested a review from a team as a code owner April 28, 2022 01:09
@BruceHaley BruceHaley requested a review from tracyboehrer April 28, 2022 01:10
@BruceHaley BruceHaley added bug Indicates an unexpected problem or an unintended behavior. Automation: No parity PR does not need to be applied to other languages. labels Apr 28, 2022
@ghost
Copy link

ghost commented Apr 28, 2022

CLA assistant check
All CLA requirements met.

@BruceHaley
Copy link
Contributor Author

Closed because checks are failing with "https://pkgs.dev.azure.com/FuseLabs/_packaging/SDK_JS_org/npm/registry/async/-/async-3.2.3.tgz: Request failed "401 Unauthorized"".

@BruceHaley BruceHaley closed this Apr 28, 2022
@BruceHaley BruceHaley deleted the bruce/cgalertfixes4-27 branch April 29, 2022 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages. bug Indicates an unexpected problem or an unintended behavior.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security Vulnerability with adal-node dependency in botframework-connector
1 participant