Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Pass qnaId in value attribute of multiturn prompts #4262

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

Arsh-Kashyap
Copy link
Contributor

Fixes #4253

Description

Store qnaId in the prompts so that its readily available everytime the prompt is clicked

Specific Changes

  • Changed prompt type from "imBack" to "messageBack"
  • pass qnaId as value in prompts
  • Check if value has qnaId before resetting dialogOptions.

Testing

@Arsh-Kashyap Arsh-Kashyap changed the title Pass qnaId in value attribute of multiturn prompts fix: Pass qnaId in value attribute of multiturn prompts Jun 9, 2022
@coveralls
Copy link

coveralls commented Jun 9, 2022

Pull Request Test Coverage Report for Build 2467656099

  • 3 of 4 (75.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.004%) to 84.477%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai/src/qnaMakerDialog.ts 3 4 75.0%
Totals Coverage Status
Change from base Build 2462448523: -0.004%
Covered Lines: 19903
Relevant Lines: 22312

💛 - Coveralls

@Arsh-Kashyap Arsh-Kashyap marked this pull request as ready for review June 10, 2022 14:13
@Arsh-Kashyap Arsh-Kashyap requested a review from a team as a code owner June 10, 2022 14:13
@tracyboehrer tracyboehrer merged commit a39a86b into microsoft:main Jun 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Custom Question Answering previous prompt buttons do not pass question ID
3 participants