Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#4276] Add Teams read receipt event (#6356) #4297

Merged
merged 2 commits into from
Aug 2, 2022
Merged

port: [#4276] Add Teams read receipt event (#6356) #4297

merged 2 commits into from
Aug 2, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4276

Description

This PR ports the changes in PR#6356 adding support for the Teams read receipt event.

Specific Changes

  • Added onTeamsReadReceiptEvent handler method in the teamsActivityHandler class.
  • Added the new ReadReceiptInfo class in botframework-connector/teams.
  • Added unit tests for the new class and methods.
  • Updated botbuilder.api.md with the new method.

Testing

These images show the new unit tests passing.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner July 28, 2022 11:50
@coveralls
Copy link

coveralls commented Jul 28, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2753547905

  • 16 of 16 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.009%) to 84.528%
Totals Coverage Status
Change from base Build 2746820595: 0.009%
Covered Lines: 19861
Relevant Lines: 22256
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 5ee4dac into main Aug 2, 2022
@tracyboehrer tracyboehrer deleted the southworks/add/teams-read-receipt-event branch August 2, 2022 13:37
This was referenced Nov 9, 2023
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: Add Teams read receipt event (#6356)
3 participants
@ceciliaavila @coveralls @tracyboehrer