Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change req to res in process method #4331

Merged
merged 1 commit into from
Oct 7, 2022
Merged

fix: change req to res in process method #4331

merged 1 commit into from
Oct 7, 2022

Conversation

bcomerford
Copy link
Contributor

@bcomerford bcomerford commented Oct 5, 2022 •
edited
Loading

Fixes #4332

Description

Fixing a very small typo from req to res to denote the correct Response object in the process method

Specific Changes

  • Change req to res

Testing

@bcomerford bcomerford requested a review from a team as a code owner October 5, 2022 17:54
@coveralls
Copy link

coveralls commented Oct 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3191578618

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 84.611%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 3101634467: -0.003%
Covered Lines: 19923
Relevant Lines: 22308
💛 - Coveralls

@johnataylor johnataylor merged commit e59dc9a into microsoft:main Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnataylor johnataylor johnataylor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Response object misnamed in botFrameworkAdapter
3 participants
@bcomerford @coveralls @johnataylor