Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6354] isMatch adaptive expression returns error when value is null or empty string (#6426) #4343

Merged
merged 1 commit into from
Oct 18, 2022
Merged

port: [#6354] isMatch adaptive expression returns error when value is null or empty string (#6426) #4343

merged 1 commit into from
Oct 18, 2022

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4310

Description

This PR ports the changes in PR#6426 to fix the error in the isMatch built-in function when the value is null or an empty string.

Specific Changes

  • Updated the IsMatch built-in function to handle empty strings and null values by the evaluator.
  • Added 2 new unit tests for empty string and null values for the IsMatch function.

Testing

Here we can see the new unit tests passing after the changes.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner October 13, 2022 19:09
@coveralls
Copy link

coveralls commented Oct 13, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3245014103

  • 4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.004%) to 84.617%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 3206725406: 0.004%
Covered Lines: 19922
Relevant Lines: 22305
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 65241c6 into main Oct 18, 2022
@tracyboehrer tracyboehrer deleted the southworks/update/port-match-null-empty branch October 18, 2022 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: [#6354] isMatch adaptive expression returns error when value is null or empty string (#6426)
3 participants
@ceciliaavila @coveralls @tracyboehrer