Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Fix the CG security vulnerability from minimist v 1.2.5 #4346

Merged
merged 3 commits into from
Oct 24, 2022
Merged

chore: Fix the CG security vulnerability from minimist v 1.2.5 #4346

merged 3 commits into from
Oct 24, 2022

Conversation

BruceHaley
Copy link
Contributor

@BruceHaley BruceHaley commented Oct 19, 2022 •
edited
Loading

Fixes #minor

Description

Update the orchestrator-core dependency to the new version 4.14.4. That version has the minimist 1.2.5 vulnerability fixed.

@BruceHaley BruceHaley changed the title Bruce/newoc10 5 chore: Update orchestrator-core reference to 4.14.4 Oct 19, 2022
@coveralls
Copy link

coveralls commented Oct 19, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 3277942965

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.003%) to 84.62%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 3274131441: -0.003%
Covered Lines: 19934
Relevant Lines: 22320
💛 - Coveralls

@BruceHaley BruceHaley changed the title chore: Update orchestrator-core reference to 4.14.4 chore: Fix the Component Governance security vulnerability for minimist 1.2.5 Oct 19, 2022
@BruceHaley BruceHaley changed the title chore: Fix the Component Governance security vulnerability for minimist 1.2.5 chore: Fix the CG security vulnerability from a dependency on minimist 1.2.5 Oct 19, 2022
@BruceHaley BruceHaley changed the title chore: Fix the CG security vulnerability from a dependency on minimist 1.2.5 chore: Fix the CG security vulnerability from minimist v 1.2.5 Oct 19, 2022
@BruceHaley BruceHaley marked this pull request as ready for review October 19, 2022 17:30
@BruceHaley BruceHaley requested a review from a team as a code owner October 19, 2022 17:30
@tracyboehrer tracyboehrer merged commit 1ca79f2 into main Oct 24, 2022
@tracyboehrer tracyboehrer deleted the bruce/newoc10-5 branch October 24, 2022 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees

@tracyboehrer tracyboehrer

@johnataylor johnataylor

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@BruceHaley @coveralls @tracyboehrer @johnataylor