fix: [CodeQL] SM01511 - Improve password hash security #4359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
@microsoft-github-policy-service agree company="southworks" |
Pull Request Test Coverage Report for Build 3428963257
💛 - Coveralls |
tracyboehrer
approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4335
#minor
Description
This PR fixes the SM01511 alerts which were related to the use of password hash with insufficient computational effort in microsoft/microsoft/botbuilder-js/botbuilder-js.
To fix it, we replaced the current password hashing scheme crypto with bcrypt.
Specific Changes
Testing