feat: teams message update & message delete events

[singhk97]

This PR aims to extend the Bot SDK so that developers can consume newly added events that Teams will emit to the bot. They are:

TeamsMessageEdit - a user editing a message in Teams.
TeamsMessageUndelete - a user undo-ing a deleted message in Teams.
TeamsMessageSoftDelete - a user deleting a message in Teams.

Closes #4375

Description

• Extended ActivityHandlerBase to handle MessageUpdate and MessageDelete activity types
• Extended ActivityHandler to handle MessageUpdate and MessageDelete activity types and dispatch functions for subtypes.
• Extended TeamsActivityHandler to handle MessageUpdate (with subtypes TeamsMessageEdit and TeamsMessageUndelete) and MessageDelete (with subtype TeamsMessageSoftDelete) teams events.

Specific Changes

• Ran yarn build:rollup on both the botbuilder and botbuilder-core libraries to generate public api doc.

ActivityHandlerBase class

• Updated switch statement to handle MessageUpdate and MessageDelete
• Defined onMessageUpdateActivity and onMessageDeleteActivity methods
• the changes conform to existing convention and are synonymous to the Message activity event.

ActivityHandler class

• Implemented event handler registration methods onMessageUpdate and onMessageDelete
• Implemented hooks onMessageUpdateActivity and onMessageDeleteActivity to mirror onConversationUpdateActivity
• Implemented subtype dispatch functions dispatchMessageUpdateAcitivty and dispatchMessageDeleteActivity. They conform to existing convention (ex. onConversationUpdateActivity).

TeamsActivityHandler class

• Extended dispatchMessageUpdateActivity to handle subtypes onTeamsMessageEdit & onTeamsMessageUndelete.
• Extended dispatchMessageDeleteActivity to handle subtypes onTeamsSoftDelete.
• Implemented event handler registration methods onTeamsMessageEditEvent, onTeamsMessageUndeleteEvent and onTeamsMessageSoftDeleteEvent.
• Implemented methods onTeamsMessageEdit, onTeamsMessageUndelete and onTeamsMessageSoftDelete that are dispatched by the respective dispatch methods.

Testing

• Added unit tests for changes in all the three classes.

[coveralls]

Pull Request Test Coverage Report for Build 3570060710

• 34 of 36 (94.44%) changed or added relevant lines in 3 files are covered.
• No unchanged relevant lines lost coverage.
• Overall coverage increased (+0.01%) to 84.633%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
libraries/botbuilder-core/src/activityHandlerBase.ts	4	6	66.67%

Totals
Change from base Build 3519043752:	0.01%
Covered Lines:	19968
Relevant Lines:	22357

---

💛 - Coveralls

[singhk97]

Pull Request Test Coverage Report for Build 3528369428

• 32 of 36 (88.89%) changed or added relevant lines in 3 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.004%) to 84.625%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-core/src/activityHandlerBase.ts 4 6 66.67%
libraries/botbuilder/src/teamsActivityHandler.ts 20 22 90.91%
Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals
Change from base Build 3519043752: 0.004%
Covered Lines: 19966
Relevant Lines: 22357

💛 - Coveralls

The 2 lines in ActivityHandlerBase.ts that aren't covered are method definitions with empty implementation

[singhk97]

@microsoft-github-policy-service agree company="Microsoft"

[yingduyingdu]

Hi @singhk97 , could you explain a bit why/how message update and message delete are related to OnConversationUpdateActivity? I am bit confused here.

[singhk97]

Hi @singhk97 , could you explain a bit why/how message update and message delete are related to OnConversationUpdateActivity? I am bit confused here.

ConversationUpdate is an activity type and MembersAdded and MembersRemoved is it's respective sub-type. When a ConversationUpdate event happens, we trigger the ConversationUpdate handlers, and then trigger its subtype's handlers (using a dispatch function). Because MessageUpdate is an activity type, while OnTeamsMessageEdit & OnTeamsMessageUndelete are their respective sub-types, It made sense to mirror the behavior of ConversationUpdate activity, implementation technique & naming convention. Same logic applies to MessageDelete. I hope this helps

[yingduyingdu]

Hi @singhk97 , could you explain a bit why/how message update and message delete are related to OnConversationUpdateActivity? I am bit confused here.

ConversationUpdate is an activity type and MembersAdded and MembersRemoved is it's respective sub-type. When a ConversationUpdate event happens, we trigger the ConversationUpdate handlers, and then trigger its subtype's handlers (using a dispatch function). Because MessageUpdate is an activity type, while OnTeamsMessageEdit & OnTeamsMessageUndelete are their respective sub-types, It made sense to mirror the behavior of ConversationUpdate activity, implementation technique & naming convention. Same logic applies to MessageDelete. I hope this helps

Make a lot more sense! Thanks for the clarification!