Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: send targeted meeting notification in Teams meetings #4385

Merged
merged 8 commits into from
Dec 22, 2022

Conversation

singhk97
Copy link
Collaborator

@singhk97 singhk97 commented Dec 8, 2022

Description

This feature aims to extend the JS Bot SDK so that developers can send targeted meeting notifications in Microsoft Teams meetings.

Closes #4384

Specific Changes

Ran yarn build:rollup on both the botbuilder, botframework-connector & botframework-schema libraries to generate public api doc.

botbuilder

  • Added sendMeetingNotification method to TeamsInfo class.

botframework-schema

  • Added multiple interfaces to the index.ts monolith of interfaces & types related to Teams meeting notifications. TeamsMeetingNotification interface defines the notification payload to the API call. All other interfaces are used to build this interface.

botframework-connector

  • Added a type to teams related model.
  • Added multiple ms-rest objects used in the ms-rest set up for the REST API call.
  • Implemented sendMeetingNotification REST API call using the existing ms-rest template.

Testing

  • Unit tests only done for changes in teamsInfo.ts from the botbuilder library.
  • botframework-schema changes are adding new types & interfaces so it doesn't make sense to have a unit test.
  • botframework-connector unit tests are done indirectly through testing teamsInfo.ts method. This follows existing precedent of a PR with a similar feature addition: port: add support for Teams get meeting participant API #2884

@coveralls
Copy link

coveralls commented Dec 8, 2022

Pull Request Test Coverage Report for Build 3651865500

  • 27 of 27 (100.0%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 84.646%

Totals Coverage Status
Change from base Build 3587703730: 0.01%
Covered Lines: 19995
Relevant Lines: 22384

💛 - Coveralls

@tracyboehrer tracyboehrer requested review from EricDahlvang and removed request for EricDahlvang December 15, 2022 18:45
@singhk97 singhk97 merged commit d331250 into main Dec 22, 2022
@singhk97 singhk97 deleted the kavin/teams-targetted-meeting-notification branch December 22, 2022 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: send targeted meeting notification in Teams meetings
5 participants