-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send targeted meeting notification in Teams meetings #4385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
singhk97
commented
Dec 8, 2022
Pull Request Test Coverage Report for Build 3651865500
💛 - Coveralls |
singhk97
commented
Dec 8, 2022
tracyboehrer
requested review from
EricDahlvang
and removed request for
EricDahlvang
December 15, 2022 18:45
johnataylor
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This feature aims to extend the JS Bot SDK so that developers can send targeted meeting notifications in Microsoft Teams meetings.
Closes #4384
Specific Changes
Ran yarn build:rollup on both the botbuilder, botframework-connector & botframework-schema libraries to generate public api doc.
botbuilder
sendMeetingNotification
method toTeamsInfo
class.botframework-schema
index.ts
monolith of interfaces & types related to Teams meeting notifications.TeamsMeetingNotification
interface defines thenotification
payload to the API call. All other interfaces are used to build this interface.botframework-connector
sendMeetingNotification
REST API call using the existing ms-rest template.Testing
teamsInfo.ts
from thebotbuilder
library.botframework-schema
changes are adding new types & interfaces so it doesn't make sense to have a unit test.botframework-connector
unit tests are done indirectly through testingteamsInfo.ts
method. This follows existing precedent of a PR with a similar feature addition: port: add support for Teams get meeting participant API #2884