Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove request package from browser-functional #4512

Merged
merged 2 commits into from
Aug 1, 2023

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR updates the nightwatch package to version 2.6.21, which doesn't require the request dependency, to avoid the security vulnerability issue.

Specific Changes

  • Updated the nightwatch version from ^1.7.13 to ^2.6.21 in browser-functional-tests.

Testing

The following image shows the pipeline browser-tests-build-ci working after the update.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner August 1, 2023 12:56
@coveralls
Copy link

coveralls commented Aug 1, 2023

Pull Request Test Coverage Report for Build 5727053722

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.86%

Totals Coverage Status
Change from base Build 5693784753: 0.0%
Covered Lines: 20135
Relevant Lines: 22485

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit e402eca into main Aug 1, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/request-package-in-nightwatch branch August 1, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants