fix: Remove request package from botbuilder-core tests #4514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 5766448576
💛 - Coveralls |
tracyboehrer
approved these changes
Aug 7, 2023
tracyboehrer
deleted the
southworks/update/remove-request-botbuilder-core
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR replaces the request package in
botbuilder-core/tests/transcriptUtilities.jswith axios to avoid the security vulnerability issue.Specific Changes
downloadAndExtractOncefunction used for the transcript tests.package.jsonyarn.lockfileTesting
This image shows one of the tests that are using the transcriptUtilities, working after the changes.
