Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#4525] Replace read-text-file package to avoid using LGPL #4534

Merged
merged 3 commits into from
Sep 8, 2023
Merged

fix: [#4525] Replace read-text-file package to avoid using LGPL #4534

merged 3 commits into from
Sep 8, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4525

Description

This PR removes the read-text-file dependency to avoid the use of LGPL.

Specific Changes

  • Replaced read and readAsync functions with fs's readFileSync and readFile in BotConfiguration class.
  • Removed read-text-file from the packages.json files.

Testing

The following image shows the botframework-config tests, which use BotConfiguration class, running successfully.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner September 8, 2023 16:40
@tracyboehrer tracyboehrer merged commit cbb187d into main Sep 8, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/remove-read-text-file-vulnerability branch September 8, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace read-text-file package to avoid using LGPL
3 participants
@ceciliaavila @tracyboehrer @JhontSouth