Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add HTTP method in fetch request #4593

Merged
merged 1 commit into from
Dec 22, 2023
Merged

fix: Add HTTP method in fetch request #4593

merged 1 commit into from
Dec 22, 2023

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR includes the HTTP method post to the fetch request.

Specific Changes

  • Added post method to the fetch request in botFrameworkClientImpl.
  • Imported fetch from cross-fetch.
  • Removed the body parse.

Testing

The following image shows a skill bot working using CloudAdapter with the botframework-connector fix.
image

@JhontSouth JhontSouth requested a review from a team as a code owner December 22, 2023 15:03
@coveralls
Copy link

coveralls commented Dec 22, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7301216761

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.541%
Totals Coverage Status
Change from base Build 7292822578: 0.0%
Covered Lines: 20416
Relevant Lines: 22872
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 709a823 into main Dec 22, 2023
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/add-fetch-http-method branch December 22, 2023 16:31
tracyboehrer pushed a commit that referenced this pull request Dec 22, 2023
@JhontSouth
include http method in fetch request (#4593)
9e74976
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JhontSouth @coveralls @tracyboehrer