Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add isVisible property to AceData #4606

Merged

Conversation

AJIXuMuK
Copy link
Contributor

Fixes #4605

Description

The PR adds isVisible property to the AceData interface to implement the #4605 feature request.

Specific Changes

interface AceData {
  // ...
  isVisible?: boolean;
  // ...
}

Testing

@AJIXuMuK AJIXuMuK requested a review from a team as a code owner January 19, 2024 16:25
@coveralls
Copy link

coveralls commented Jan 19, 2024

Pull Request Test Coverage Report for Build 7586922677

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.477%

Totals Coverage Status
Change from base Build 7576208802: 0.0%
Covered Lines: 20411
Relevant Lines: 22877

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 6b2656b into microsoft:main Jan 19, 2024
12 checks passed
@AJIXuMuK AJIXuMuK deleted the user/aterentiev/bot-ace-is-visible branch January 19, 2024 17:35
tracyboehrer pushed a commit that referenced this pull request Jan 24, 2024
* Add isVisible property to AceData

* extra comment

* updated md

---------

Co-authored-by: aterentiev <aterentiev@microsoft.com_odspmdb>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for isVisible property in SharePoint Bot Adaptive Card Extension
3 participants