fix: Remove old @microsoft/recognizers-text-number version with postinstall scripts #4608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 7626548897
💛 - Coveralls |
tracyboehrer
approved these changes
Jan 24, 2024
tracyboehrer
deleted the
southworks/fix/recognizer-text-number-old-version
branch
tracyboehrer
pushed a commit
that referenced
this pull request
Jan 24, 2024
…nstall scripts (#4608) * add recognizers-text-number resolution * add scripts to remove old version of recognizers-text-number * remove rimraf package
|
By using Yarn in the post-install script, you're FORCING a dependency on anyone using your package must have Yarn installed. WHY? Why not use NPM? It's fine if you use Yarn in your dev & builds, but to force it on ALL consumers of the package? 👎👎 For example, if a user doesn't have Yarn installed, this breaks all builds of new Teams projects created with TTK (see my referenced bug above |
|
@andrewconnell Apologies. We'll take care of it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#minor
Description
This PR removes the old version or @microsoft/recognizers-text-number from the other recognizers packages that require it.
Specific Changes
Testing
These images show the dependencies tree before and after running the postinstall scripts.
