Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [#4584] ChannelAccount cannot accept extensible properties #4618

Merged
merged 2 commits into from
Feb 13, 2024

Conversation

JhontSouth
Copy link
Collaborator

Fixes #4584

Description

This PR includes the Properties property to the ChannelAccount interface to allow using optional properties.

Specific Changes

  • Added Properties property to the ChannelAccount interface.
  • Added properties serialization in CompositeMapper.

Testing

The following image shows the object Properties retrieved in the request body of the bot.
image

@JhontSouth JhontSouth requested a review from a team as a code owner February 13, 2024 13:48
@coveralls
Copy link

coveralls commented Feb 13, 2024

Pull Request Test Coverage Report for Build 7887493284

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.48%

Totals Coverage Status
Change from base Build 7747869028: 0.0%
Covered Lines: 20414
Relevant Lines: 22880

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 9ffca8d into main Feb 13, 2024
12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/optional-properties-channelaccount branch February 13, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChannelAccount cannot accept extensible properties
3 participants