Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove CVE-2022-25881 vulnerability by updating the http-cache-semantics package #4703

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR updates the version of the http-cache-semantics package to 4.1.1 to fix the CVE-2022-25881 vulnerability.
Along the way, to address this http-cache-semantics package issue with 3.x version, we removed bf-chatdown package, and ported its code to botbuilder-core as internal testing, to remove unnecessary vulnerable dependencies the project isn't using.
Additionally, the lodash.template https://github.com/microsoft/botbuilder-js/security/dependabot/344 - CVE-2021-23337 was also address.

Specific Changes

  • Updated http-cache-semantics to 4.1.1.
  • Removed bf-chatdown as it was using http-cache-semantics 3.x version.
  • Ported and adapted bf-chatdown code to botbuilder-core for internal testing.
  • Fixed transcripts tests to work with latest botbuilder changes.
  • Added transcripts tests to the testing flow.
  • Fixed lint errors with chatdown and botbuilder-dialogs-adaptive.

Testing

The following image shows the http-cache-semantics updated version, and the trascripts tests passing.
imagen

@sw-joelmut sw-joelmut requested a review from tracyboehrer June 28, 2024 18:14
@sw-joelmut sw-joelmut requested a review from a team as a code owner June 28, 2024 18:14
@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9762746690

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 84.075%

Totals Coverage Status
Change from base Build 9715766910: -0.4%
Covered Lines: 20343
Relevant Lines: 22900

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9762746690

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.431%

Totals Coverage Status
Change from base Build 9715766910: 0.0%
Covered Lines: 20425
Relevant Lines: 22900

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jul 2, 2024

Pull Request Test Coverage Report for Build 9763576686

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 79 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.4%) to 84.078%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-dialogs-adaptive/src/adaptiveDialog.ts 79 73.33%
Totals Coverage Status
Change from base Build 9715766910: -0.4%
Covered Lines: 20347
Relevant Lines: 22904

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 59e4da3 into main Jul 2, 2024
11 of 12 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/http-cache-semantics branch July 2, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants