Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade express dependency to latest version #4747

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR fixes the 'outputs backtracking regular expressions' issue with the path-to-regexp package by upgrading it to a safe version.

Specific Changes

  • Upgraded express dependency to the latest version 4.21.0 in botbuilder-dialogs-adaptive-runtime-integration-express and testing/bot-integration to upgrade the transitive dependency path-to-regex.

Testing

This image shows the safe version of the path-to-regex package being installed.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner September 17, 2024 13:55
@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10904560093

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.407%

Totals Coverage Status
Change from base Build 10800481624: 0.0%
Covered Lines: 20433
Relevant Lines: 22910

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 6203163 into main Sep 17, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/path-to-regexp-issue branch September 17, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants