Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Upgrade send dependency to latest version #4749

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

ceciliaavila
Copy link
Collaborator

#minor

Description

This PR fixes the 'vulnerable to template injection that can lead to XSS' issue with the send package by upgrading it to a safe version.

Specific Changes

  • Updated the testing/browser-functional/browser-echo-bot/yarn.lock file, removing old version of the send package so the new version could be resolved when reinstalling.
  • Added the correct version of send to the resolutions section in package.json.

Testing

These images show the safe version of the send package being installed.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner September 17, 2024 20:26
@coveralls
Copy link

coveralls commented Sep 17, 2024

Pull Request Test Coverage Report for Build 10910564005

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.407%

Totals Coverage Status
Change from base Build 10905035083: 0.0%
Covered Lines: 20433
Relevant Lines: 22910

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 2900d57 into main Sep 17, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/send-vulnerability branch September 17, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants