Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: [#4684] Upgrade Nighwatch #4768

Merged
merged 5 commits into from
Oct 30, 2024
Merged

Conversation

sw-joelmut
Copy link
Collaborator

Addresses #4684
#minor

Description

This PR updates Nightwatch to its latest version. Modifying the existing Nightwatch files to use the new configuration and browser driver validation.

Specific Changes

  • Updates Nighwatch from ^2.6.2 to ^3.7.0.
  • Added nohoist property to workspaces to exclude @types/selenium-webdriver as it requires being ES6+.
  • Updated browser functional pipeline to the new structure.
  • Added new Nightwatch config.
  • Added new Nightwatch browser and driver validation.
  • Improved echo page and tests files.

Testing

The following image shows the pipeline and the new test structure working as expected.
image
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner October 15, 2024 13:19
@coveralls
Copy link

coveralls commented Oct 15, 2024

Pull Request Test Coverage Report for Build 11593415687

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.703%

Totals Coverage Status
Change from base Build 11579384597: 0.0%
Covered Lines: 20514
Relevant Lines: 23063

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 2bdedaa into main Oct 30, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/update/nightwatch branch October 30, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants