Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Workspaces for update-versions script #4783

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

sw-joelmut
Copy link
Collaborator

#minor

Description

This PR fixes an issue with the update-versions script that didn't work with the latest workspaces changes.

Specific Changes

  • Changed workspaces type to use packages property instead of an array.
  • Added unit tests to check if the command is running properly without altering the existing package.json files (using sinon).

Testing

The following image shows the script working, and the new unit test.
image
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner November 1, 2024 17:22
@coveralls
Copy link

coveralls commented Nov 1, 2024

Pull Request Test Coverage Report for Build 11633498457

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.704%

Totals Coverage Status
Change from base Build 11629347935: 0.0%
Covered Lines: 20515
Relevant Lines: 23064

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 3dd1c6a into main Nov 1, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/fix/update-versions-workspaces branch November 1, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants