Add ShowTypingMiddleware #507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1761
💛 - Coveralls |
johnataylor
approved these changes
Oct 2, 2018
Stevenic
reviewed
Oct 2, 2018
…tor. Update tests
Stevenic
reviewed
Oct 3, 2018
| if (context.activity.type === ActivityTypes.Message) { | ||
| // Set a property to track whether or not the turn is finished. | ||
| // When it flips to true, we won't send anymore typing indicators. | ||
| this.finished = false; |
There was a problem hiding this comment.
this.finished = false; [](start = 16, length = 22)
What if you have a hundred simultaneous requests? If anything you should store this flag in TurnContext.turnState. You can use a Symbol() for the key to avoid name collisions. Take a look at BotState for an example of that.
There was a problem hiding this comment.
Yeah whoops!
I've updated this to be a local variable which should resolve the rush condition/state issues.
|
Any more feedback on this, @Stevenic? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a ShowTypingMiddleware to botbuilder-core, as well as some unit tests.
This is basically a port of the dotnet version, with some slight changes for Javascript.
Should address #470.