-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add BotTelemetry instrumentation and utilities #662
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move definition of interface to botbuilder-core adjust field names and content for telemetry objects
…js into daveta-appsight-js
2 tasks
Still need to:
|
This was referenced Nov 27, 2018
I have verified that, when used alongside the ABS channel service and the samples enabled with AppInsights, all the data is properly correlated by user and session. Seems correct! |
Pull Request Test Coverage Report for Build 2394
💛 - Coveralls |
daveta
reviewed
Nov 28, 2018
daveta
reviewed
Nov 28, 2018
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
daveta
reviewed
Nov 28, 2018
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
Track waterfallStart event add instanceid to calls to trackEvent
add some coments
daveta
approved these changes
Nov 30, 2018
justinwilaby
suggested changes
Nov 30, 2018
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-applicationinsights/src/applicationInsightsTelemetryClient.ts
Outdated
Show resolved
Hide resolved
libraries/botbuilder-applicationinsights/tests/TelemetryWaterfallTest.js
Outdated
Show resolved
Hide resolved
justinwilaby
approved these changes
Dec 3, 2018
clean up some code style issues in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #629
Fixes #628
Fixes #627
Fixes #626
Fixes #624
Description
Adds Application Insight support in Waterfall Dialogs, and exposes an interface for creating custom telemetry clients.
Specific Changes
In botbuilder-core:
In botbuilder-dialogs:
telemetryClient
field to the dialog class which defaults to a NullButTelemetryClient. Can be set to any object that implements the interface, including botbuilder-applicationinsights below.In botbuilder-applicationinsights:
applicationinsights
module and handles the somewhat ugly instantiation of that library.ApplicationInsightsContextWebserverMiddleware
function, a middleware which can be used by Restify or Express to handle necessary context-setting operations.Testing
To your bot application, add:
const { ApplicationInsightsTelemetryClient, ApplicationInsightsWebserverMiddleware } = require('botbuilder-applicationinsights');
Before any other modules are imported into your application, call:
const appInsightsClient = new ApplicationInsightsTelemetryClient(process.env.instrumentationKey);
After setting up your webserver, add:
server.use(ApplicationInsightsWebserverMiddleware);
And finally, to any dialog you want to track, add:
mainDialog.telemetryClient = appInsightsClient;