Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add full nock validation for LUIS calls #796

Merged
merged 1 commit into from
Feb 22, 2019
Merged

add full nock validation for LUIS calls #796

merged 1 commit into from
Feb 22, 2019

Conversation

johnataylor
Copy link
Member

additional validation for:

  • full path including appId, not just regex match for 'apps'
  • query string
  • subscription key in headers (twice)
  • request content

@johnataylor
Copy link
Member Author

Note this is a PR for master not for 4.3 branch. This is test code.

@coveralls
Copy link

Pull Request Test Coverage Report for Build #2011

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.06%) to 87.5%
Totals Coverage Status
Change from base Build #2009: 0.06%
Covered Lines: 3006
Relevant Lines: 3306
💛 - Coveralls

stevengum
stevengum approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much needed :shipit:

@johnataylor johnataylor merged commit 16a307f into master Feb 22, 2019
@johnataylor johnataylor deleted the johtaylo/luis-test-improvement branch February 22, 2019 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevengum stevengum stevengum approved these changes

@cleemullins cleemullins Awaiting requested review from cleemullins

@daveta daveta Awaiting requested review from daveta

@sgellock sgellock Awaiting requested review from sgellock

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnataylor @coveralls @stevengum