Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Luis SDK tests (oracle) #800

Merged
merged 2 commits into from
Mar 1, 2019
Merged

Luis SDK tests (oracle) #800

merged 2 commits into from
Mar 1, 2019

Conversation

daveta
Copy link
Contributor

@daveta daveta commented Feb 24, 2019

SDK tests (ported oracle tests) based on recognizer tests..

We can augment with more. Separate package we can supply to Autorest team.

Based on @chrimc62 oracle tests.

@daveta daveta requested review from johnataylor and cahann February 24, 2019 03:07
@coveralls
Copy link

coveralls commented Feb 24, 2019

Pull Request Test Coverage Report for Build #2026

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 87.441%

Totals Coverage Status
Change from base Build #2025: 0.0%
Covered Lines: 3004
Relevant Lines: 3306

💛 - Coveralls

@cleemullins
Copy link
Contributor

Should we have these same tests on the C# Side? Seems like we probably should.

@cleemullins
Copy link
Contributor

@daveta - Please merge when ready. :)

@daveta daveta merged commit 027da3c into master Mar 1, 2019
@cleemullins cleemullins deleted the daveta-sdktests branch March 5, 2019 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants