Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace async-file with fs-extra to match other packages #805

Merged
merged 2 commits into from
Mar 7, 2019

Conversation

benbrown
Copy link
Contributor

@benbrown benbrown commented Mar 5, 2019

Fixes #786

Description

Replace async-file package with fs-extra.

These packages provide the same functionality with slightly different syntax.

Removing dependence on async-file reduces the packages we need to worry about.

Specific Changes

  • replaced dependence in package file
  • replaced calls to .delete with .remove
  • replaced calls to .exists with .pathExists

Testing

Run existing tests

@coveralls
Copy link

Pull Request Test Coverage Report for Build #2040

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 87.52%

Totals Coverage Status
Change from base Build #2032: 0.02%
Covered Lines: 3006
Relevant Lines: 3306

💛 - Coveralls

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@sgellock, should we start pinning dependencies as we add/change them and then pin the other libraries' dependencies as part of a work item?

@sgellock
Copy link
Member

sgellock commented Mar 7, 2019

I'd propose we lock any sagger generated dependencies. Any of our 1st party components, e.g timex, etc. for 3rd party components, I'd propose we use ~ versioning and not ^ versioning.

@benbrown benbrown merged commit 877b05f into master Mar 7, 2019
@benbrown benbrown deleted the benbrown/786 branch March 7, 2019 19:31
@benbrown
Copy link
Contributor Author

benbrown commented Mar 7, 2019

thank you gentlemen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants