New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QnA Telemetry Support #822

Merged

daveta merged 1 commit into master from daveta-telemetry-js-qna

Mar 18, 2019

Contributor

daveta commented Mar 15, 2019

Adds Telemetry support to QnAMaker

Shares same pattern as Luis and TelemetryMiddleware.

Enables setting properties during GetAnswersAsync
Enables deriving from class and adding properties
https://github.com/daveta/analytics/blob/master/telemetry_enhancements/TelemetryEnhancements.md#telemetry-qna-recognizer

C# Version: microsoft/botbuilder-dotnet#1430


          Bump to latest luis SDK package

87e4758

coveralls commented Mar 15, 2019 •

edited

Loading

Pull Request Test Coverage Report for Build #2088

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.08%) to 87.441%

Files with Coverage Reduction	New Missed Lines	%
libraries/botframework-config/src/botConfigurationBase.ts	2	85.59%

Totals
Change from base Build #2041:	-0.08%
Covered Lines:	3004
Relevant Lines:	3306

💛 - Coveralls

daveta merged commit 87e4758 into master

daveta deleted the daveta-telemetry-js-qna branch

March 19, 2019 15:54

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet