Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line channel updates #834

Merged
merged 3 commits into from
Apr 3, 2019
Merged

Line channel updates #834

merged 3 commits into from
Apr 3, 2019

Conversation

EricDahlvang
Copy link
Member

Fixes microsoft/botframework-sdk#5316
and
microsoft/botframework-sdk#5313

OAuthPrompt (line works with OAuthPrompt)

Dialogs Channel: added LIne
- SupportsSuggestedActions: 13
- SupportsCardActions: 99

Channel Constant: added Line

Add tests for Line, and fixed other choices_channel tests.

@coveralls
Copy link

coveralls commented Mar 23, 2019

Pull Request Test Coverage Report for Build #2157

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 87.59%

Files with Coverage Reduction New Missed Lines %
libraries/botframework-config/src/botConfigurationBase.ts 2 85.59%
Totals Coverage Status
Change from base Build #2153: -0.03%
Covered Lines: 3192
Relevant Lines: 3501

💛 - Coveralls

@EricDahlvang EricDahlvang merged commit 125f140 into master Apr 3, 2019
@EricDahlvang EricDahlvang deleted the eric/lineChannelUpdates branch April 3, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LINE: Update channel constants in SDKs
3 participants