Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix AzureBlobTranscriptStore #836

Merged
merged 2 commits into from
Mar 26, 2019
Merged

Fix AzureBlobTranscriptStore #836

merged 2 commits into from
Mar 26, 2019

Conversation

gasper-az
Copy link
Contributor

Fixes #808

Description

  • Removed 'Async' keyword from createBlobService's Proxy
  • Fixed methods that weren't being awaited and were overlapping
  • Fixed tests that were calling callback methods as a promise

Testing

image

@JuanAr JuanAr mentioned this pull request Mar 25, 2019
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build #2118

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 87.562%
Totals Coverage Status
Change from base Build #2104: -0.01%
Covered Lines: 3190
Relevant Lines: 3499
💛 - Coveralls

EricDahlvang
EricDahlvang approved these changes Mar 25, 2019
View reviewed changes
Copy link
Member

@EricDahlvang EricDahlvang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Previously approved: #809 (automated build now passing)

Thanks!

@EricDahlvang EricDahlvang merged commit b82a4c3 into master Mar 26, 2019
@cleemullins cleemullins mentioned this pull request Apr 9, 2019
Closed
@EricDahlvang EricDahlvang deleted the fix/azure-blob-transcript-store branch April 10, 2019 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricDahlvang EricDahlvang EricDahlvang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gasper-az @coveralls @EricDahlvang @ParadoxARG