Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

choice prompt parity #875

Merged
merged 4 commits into from
Apr 17, 2019
Merged

choice prompt parity #875

merged 4 commits into from
Apr 17, 2019

Conversation

Zerryth
Copy link
Contributor

@Zerryth Zerryth commented Apr 15, 2019

Fixes #852 and #869

Description

  • Parity with C# - Ability to change the Prompt Styling through dc.prompt()
  • Fix bug that ignored 3rd choices paramater if PromptOptions (as opposed to string) was passed in as 2nd arg to dc.prompt()

@Zerryth Zerryth changed the title Zerryth/choice prompt parity choice prompt parity Apr 15, 2019
@Zerryth Zerryth requested review from Stevenic and cleemullins April 15, 2019 14:21
@coveralls
Copy link

coveralls commented Apr 15, 2019 •
edited
Loading

Pull Request Test Coverage Report for Build #2192

  • 6 of 6 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 88.214%
Totals Coverage Status
Change from base Build #2188: 0.02%
Covered Lines: 3235
Relevant Lines: 3524
💛 - Coveralls

@Zerryth
Copy link
Contributor Author

Zerryth commented Apr 17, 2019

ping @Stevenic or @cleemullins :)

@gabog gabog merged commit b6f1f56 into master Apr 17, 2019
@gabog gabog deleted the Zerryth/ChoicePromptParity branch April 17, 2019 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabog gabog gabog approved these changes

@Stevenic Stevenic Awaiting requested review from Stevenic

@cleemullins cleemullins Awaiting requested review from cleemullins

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Parity Issue] Ability to change the Prompt Styling through PromptAsync
3 participants
@Zerryth @coveralls @gabog