Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency: update node.js app insights sdk to 1.2.0 #879

Merged
merged 4 commits into from
Apr 18, 2019
Merged

Dependency: update node.js app insights sdk to 1.2.0 #879

merged 4 commits into from
Apr 18, 2019

Conversation

markwolff
Copy link

@markwolff markwolff commented Apr 17, 2019

Description

Update version of node.js app insights SDK. Versions >= 1.1.0 are much more stable as it deprecates usage of zone.js.
https://github.com/Microsoft/ApplicationInsights-node.js/releases

@markwolff markwolff changed the title Update package.json Dependency: update node.js app insights sdk to 1.2.0 Apr 17, 2019
@jspruance
Copy link

If we're updating an npm package we probably want to commit the corresponding 'package-lock.json' change as well.

Copy link

@jspruance jspruance left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment on 'package-lock.json'

@coveralls
Copy link

Pull Request Test Coverage Report for Build #2205

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.287%

Totals Coverage Status
Change from base Build #2203: 0.0%
Covered Lines: 3237
Relevant Lines: 3524

💛 - Coveralls

@jspruance jspruance merged commit baa6fd4 into microsoft:master Apr 18, 2019
@markwolff markwolff deleted the patch-1 branch April 18, 2019 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants