Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow patch version of ms-rest to float. #893

Merged
merged 1 commit into from
Apr 25, 2019
Merged

Conversation

cleemullins
Copy link
Contributor

The Cognitive Services project allows the Azure@MS-Rest-Json package version to float. This means when a new version of that package is published (as it was today), our build breaks with Typescript errors.

Allowing this to float should help keep them in sync.

@cleemullins cleemullins added 4.4 April 15, 2019 Release P0 Must Fix. Release-blocker labels Apr 25, 2019
@cleemullins cleemullins self-assigned this Apr 25, 2019
@cleemullins cleemullins requested a review from johnataylor April 25, 2019 22:56
@coveralls
Copy link

Pull Request Test Coverage Report for Build #2225

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 88.311%

Totals Coverage Status
Change from base Build #2224: 0.0%
Covered Lines: 3247
Relevant Lines: 3532

💛 - Coveralls

@johnataylor johnataylor merged commit 6ffc0d9 into master Apr 25, 2019
@johnataylor johnataylor deleted the CLM/FixMSRestVersion branch April 25, 2019 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.4 April 15, 2019 Release P0 Must Fix. Release-blocker
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants