Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issues found in testing with Teams #900

Merged
merged 1 commit into from
Apr 28, 2019
Merged

fix issues found in testing with Teams #900

merged 1 commit into from
Apr 28, 2019

Conversation

johnataylor
Copy link
Member

@johnataylor johnataylor commented Apr 28, 2019 •
edited
Loading

  • add trim to text in message for inspect command processing
  • fix default parameter logic on constructor (specifically allow plain objects for creds)
  • remove type coercion in command processing

@coveralls
Copy link

Pull Request Test Coverage Report for Build #2235

  • 0 of 6 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 85.692%
Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder/src/inspectionMiddleware.ts 0 6 0.0%
Totals Coverage Status
Change from base Build #2232: 0.02%
Covered Lines: 3258
Relevant Lines: 3666
💛 - Coveralls

@johnataylor johnataylor requested a review from cleemullins April 28, 2019 00:28
sgellock
sgellock reviewed Apr 28, 2019
View reviewed changes
Copy link
Member

@sgellock sgellock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks solid John

@cleemullins cleemullins merged commit b11acc3 into master Apr 28, 2019
@cleemullins cleemullins deleted the johtaylo/sidecarissues branch April 28, 2019 17:49
@cleemullins cleemullins restored the johtaylo/sidecarissues branch April 28, 2019 17:56
@stevengum stevengum deleted the johtaylo/sidecarissues branch October 24, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgellock sgellock sgellock left review comments

@cleemullins cleemullins cleemullins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@johnataylor @coveralls @sgellock @cleemullins