[BotBuilder-AI] Remove 'html-entities' from QnA Maker class

[gasper-az]

Description

• Remove html-entities library and its decoding from the answer formatting.

Specific Changes

At this moment when the QnA Maker class in BotBuilder AI receives an answer that contains enconded HTML entities, said entities are decoded before returning the answer.

Remove this behaviour from the QnA Maker answer formatting, as this responsibility should be delegated to the user consuming the answer.

Testing

We did a couple of tests using both the NodeJS and .NET version of the class.
A knowledge base was created with a single answer containing several encoded HTML entities.

We tested the answer from the knowledge base by adding it to a console.log() and the sendActivity() using the Echo Browser bot sample.

As seen in the image above, the answer returned by the QnA Maker class does not match the answer stored in the knowledge base.

We also compared the behaviour of the JavaScript class against the .NET class replicating the same test.

This test confirms that the behaviour of the QnA Maker class in .NET does not decode the HTML entities before returning the answer.

[coveralls]

Pull Request Test Coverage Report for Build #2254

• 0 of 0 changed or added relevant lines in 0 files are covered.
• 2 unchanged lines in 1 file lost coverage.
• Overall coverage decreased (-0.06%) to 85.684%

---

Files with Coverage Reduction	New Missed Lines	%
libraries/botframework-config/src/botConfigurationBase.ts	2	85.59%

Totals
Change from base Build #2252:	-0.06%
Covered Lines:	3255
Relevant Lines:	3663

---

💛 - Coveralls

[cleemullins]

This looks reasonable to me, as that delegation seems odd.

@Zerryth?

[Zerryth]

Seems good to me