-
Notifications
You must be signed in to change notification settings - Fork 281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add functional test to check bot deployed answer #919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 60136
💛 - Coveralls |
Bill7zz
force-pushed
the
feature/functional-test-bot
branch
from
May 9, 2019 21:04
d8b7425
to
f80e0af
Compare
…osoft/botbuilder-js into feature/functional-test-bot
- Update AppServicePlan Region - Update ZipUrl template to get an echo bot
Bill7zz
force-pushed
the
feature/functional-test-bot
branch
from
May 21, 2019 14:37
0682401
to
5e644fd
Compare
…osoft/botbuilder-js into feature/functional-test-bot
cleemullins
approved these changes
Jun 5, 2019
stevengum
reviewed
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Add functional test to send and receive messages to bot deployed in Azure.
Description
In this pull request, we added a new functional test to check an answer from a bot deployed in Azure.
To run the test is necessary to configure a pipeline that Deploys a bot in Azure and create a Direct Line channel to connect it.
Steps to configure the pipeline
Created a new pipeline and connect with the branch that runs a the functional test.
Note: You can create those variables by entering on the Application Registration Portal.
Note: You need to add an Azure Resource Manager service connection.
“…”
next to the Override Parameters textbox and complete the field we highlighted on the image bellow (serverfarmName, siteName, appId, appSecret and botId) using quotation marks.You can find the autocompleted field below:
The script looks likes:
call az bot prepare-deploy --code-dir "$(System.DefaultWorkingDirectory)/libraries/testbot" --lang Javascript
The script looks likes:
The script looks likes:
The script looks likes:
functional-test
commandThe script looks likes:
call az group delete -n "$(TestBotName)" --yes
We strongly recommend setting this task to run even if any of the previous tasks have failed or the build has been canceled. With this setting, we will ensure that the resources will be deleted from Azure even if the build fails at any step.
Testing
We configured and ran a Build Pipeline to test the steps guide and the functional test logic. The result can be seen in the image below.