Swagger connector api updates #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging in latest from master |
jspruance
commented
Jun 12, 2019
jspruance
commented
Jun 12, 2019
jspruance
commented
Jun 12, 2019
jspruance
commented
Jun 12, 2019
| @@ -288,6 +288,10 @@ export interface SemanticAction { | |||
| * ID of this action | |||
There was a problem hiding this comment.
Add state property to semanticAction field (on Activity)
jspruance
commented
Jun 12, 2019
| @@ -480,7 +488,7 @@ export interface Activity { | |||
| /** | |||
| * An optional programmatic action accompanying this request | |||
| */ | |||
There was a problem hiding this comment.
This should be optional, per code comments
jspruance
commented
Jun 12, 2019
jspruance
commented
Jun 12, 2019
gabog
approved these changes
Jun 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #943 - 'Add State field to Semantic Action in Schema'
Description
This pull request contains updates for the Connector API, based on changes in the swagger spec since Nov 2018:
https://github.com/microsoft/botframework-sdk/blob/master/specs/botframework-protocol/botframework-channel.json
Specific Changes
Change log:
'localTimestamp' - update description
'localTimezone - update description
botbuilder-js\libraries\botframework-schema\src\index.ts
botbuilder-js\libraries\botframework-schema\src\activityInterfaces.ts
SemanticActions / SemanticActionStates - add 'state' field:
botbuilder-js\libraries\botframework-schema\src\index.ts
botbuilder-js\libraries\botframework-connector\src\connectorApi\models\mappers.ts
ConversationParameters / add 'tenantId' field
botbuilder-js\libraries\botframework-schema\src\index.ts (ALREADY EXISTS - NO CHANGE)
botbuilder-js\libraries\botframework-connector\src\connectorApi\models\mappers.ts
ConversationAccount / add 'tenantId' field
botbuilder-js\libraries\botframework-schema\src\index.ts (ALREADY EXISTS - NO CHANGE)
botbuilder-js\libraries\botframework-connector\src\connectorApi\models\mappers.ts
TokenResponse / add 'channelId' field
botbuilder-js\libraries\botframework-connector\src\tokenApi\models\index.ts (ALREADY EXISTS - NO CHANGE)
botbuilder-js\libraries\botframework-connector\src\tokenApi\models\mappers.ts (ALREADY EXISTS - NO CHANGE)
botbuilder-js\libraries\botframework-schema\src\index.ts
botbuilder-js\libraries\botframework-connector\src\connectorApi\models\mappers.ts
AttachmentView viewId / size descriptions
botbuilder-js\libraries\botframework-schema\src\index.ts
Activity / add 'callerId' field
botbuilder-js\libraries\botframework-schema\src\index.ts
botbuilder-js\libraries\botframework-connector\src\connectorApi\models\mappers.ts
Testing