Add ability to pass LUIS prediction options into Recognizer.recognize method #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merge in latest from master. |
jspruance
changed the title
cleemullins
approved these changes
Jun 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #964
Description
Add ability for Recognizer.recognize method to accept user-defined luis prediction options and use the properties present in that particular request, defaulting to the options set by the class constructor otherwise.
Specific Changes
-- Added additional parameter to 'recognize' method to accept user-defined luis prediction options.
-- Added private method 'setLuisPredictionOptions' to merge the user-defined and default options objects (and to make it testable).
Testing
Tests added to:
libraries/botbuilder-ai/tests/luisRecognizer.test.js