Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove random from auto assigned ids #998

Merged
merged 2 commits into from
Jun 17, 2019
Merged

remove random from auto assigned ids #998

merged 2 commits into from
Jun 17, 2019

Conversation

mdrichardson
Copy link
Contributor

Fixes #928

Description

Modeled directly after microsoft/botbuilder-dotnet#2069

Specific Changes

  • only assign if id is null or empty
  • only check for duplicate if user is giving their own unique id
  • using random() is inefficient, switch to just identifying the next available slot with single scan.

Testing

image

@cleemullins cleemullins merged commit 80c46f9 into microsoft:master Jun 17, 2019
@mdrichardson mdrichardson deleted the 255loopFix branch June 17, 2019 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cleemullins cleemullins cleemullins approved these changes

@johnataylor johnataylor Awaiting requested review from johnataylor

@tomlm tomlm Awaiting requested review from tomlm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Infinit loop with more than 255 services
2 participants
@mdrichardson @cleemullins