Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply conversation reference in TurnContext.update_activity #358

Merged
merged 2 commits into from
Oct 24, 2019
Merged

Apply conversation reference in TurnContext.update_activity #358

merged 2 commits into from
Oct 24, 2019

Conversation

v-kydela
Copy link

Fixes microsoft/botbuilder-dotnet#2388

Parity with .NET and Node.js

@v-kydela v-kydela requested review from axelsrz and stevengum October 24, 2019 20:34
axelsrz
axelsrz approved these changes Oct 24, 2019
View reviewed changes
Copy link
Member

@axelsrz axelsrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, thank you!

@axelsrz axelsrz merged commit d247303 into master Oct 24, 2019
@axelsrz axelsrz deleted the v-kydela/update_activity branch October 24, 2019 20:52
axelsrz added a commit that referenced this pull request Oct 24, 2019
@axelsrz
Merge master into 4.5.0b5 (#360)
f352df5 
* Apply conversation reference in TurnContext.update_activity (#358)

* Create test_update_activity_should_apply_conversation_reference

* Apply conversation reference in TurnContext.update_activity

* Added trace activity helper in turn context (#359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@axelsrz axelsrz axelsrz approved these changes

@stevengum stevengum Awaiting requested review from stevengum

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TurnContext.UpdateActivity does not apply a conversation reference
2 participants
@v-kydela @axelsrz