Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bf-orchestrator: Add Node V16 support #1258

Open
taicchoumsft opened this issue Jun 30, 2021 · 1 comment
Open

bf-orchestrator: Add Node V16 support #1258

taicchoumsft opened this issue Jun 30, 2021 · 1 comment
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.

Comments

@taicchoumsft
Copy link

taicchoumsft commented Jun 30, 2021 •
edited
Loading

Node V16 support for bf-orchestrator is a nice to have since it goes into LTS in October, and orchestrator-core already has support for Node V16.

We get this error today when building in Composer with Node V16 (as far as we know, this is the only dependency that has Node V16 restriction for Composer):

error @microsoft/bf-orchestrator@4.13.0-rc0: The engine "node" is incompatible with this module. Expected version "^10.0.0 || ^12.0.0 || ^13.0.0 || ^14.0.0". Got "16.4.0"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

Describe the solution you'd like
Modify the orchestratorlib (and other Orchestrator supporting libs)package.json engine compatibility to include Node V16, since orchestrator-core already builds for Node V16.
@taicchoumsft taicchoumsft added needs-triage The issue has just been created and it has not been reviewed by the team. feature-request A request for new functionality or an enhancement to an existing one. labels Jun 30, 2021
@taicchoumsft taicchoumsft mentioned this issue Jun 30, 2021
Merged
@Vivihung
Copy link
Member

Vivihung commented Nov 7, 2023

+1 but we need the latest Node support beyond v16. I don't want to downgrade my Node for using this lib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A request for new functionality or an enhancement to an existing one. needs-triage The issue has just been created and it has not been reviewed by the team.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Vivihung @taicchoumsft