-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Do not merge] Add section support #139
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a significant drop in coverage. Need additional tests. We should also review the back-compat issue with always expecting ## to be a sub-section.
The test coverage drop mainly comes from newly added CRUD operations in luParser.js. Will add more tests soon. |
We can review this once
@feich-ms please update this PR once the changes are in. |
…t/botframework-cli into feich/AddSectionSupport
|
@feich-ms We discussed this in BF-CLI review meeting today and decided to take these + other related changes for composer into a composer branch once we are locked down for ignite release (hopefully this week). So marking this as Do not merge. The only changes we want to take to master for now are related to Ignite deliverables. |
@vishwacsena, Ok, please let me know when the composer branch is ready. Thanks. |
Close this PR first, since all the composer related changes including section and section CRUD support are in this branch https://github.com/microsoft/botframework-cli/tree/composer now. When it is decided to go into the master, we can create a new PR then. |
Add section support in lu file. Fixes microsoft/BotFramework-Composer#733