Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add QnA TestDevSpec #919

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add QnA TestDevSpec #919

wants to merge 1 commit into from

Conversation

xhr0804
Copy link
Contributor

@xhr0804 xhr0804 commented Aug 4, 2020

spec to bring bf qna test

@codecov-commenter
Copy link

Codecov Report

Merging #919 into master will increase coverage by 1.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
+ Coverage   55.83%   56.84%   +1.01%     
==========================================
  Files         220      219       -1     
  Lines       16181    16959     +778     
  Branches     2328     2345      +17     
==========================================
+ Hits         9034     9641     +607     
- Misses       6569     6725     +156     
- Partials      578      593      +15     
Impacted Files Coverage Δ
packages/lg/src/commands/lg/index.ts 66.66% <0.00%> (-16.67%) ⬇️
packages/lu/src/utils/textfilereader.ts 28.57% <0.00%> (-15.43%) ⬇️
...kages/qnamaker/src/commands/qnamaker/kb/publish.ts 85.71% <0.00%> (-14.29%) ⬇️
...aker/src/commands/qnamaker/endpointkeys/refresh.ts 85.71% <0.00%> (-14.29%) ⬇️
...atics/confusion_matrix/AppBinaryConfusionMatrix.ts 85.71% <0.00%> (-14.29%) ⬇️
...ematics/mathematics_helper/AppMathematicsHelper.ts 86.36% <0.00%> (-13.64%) ⬇️
packages/qnamaker/src/utils/qnamakerbase.ts 71.64% <0.00%> (-8.72%) ⬇️
packages/lu/src/parser/lu/lu.js 91.66% <0.00%> (-8.34%) ⬇️
packages/qnamaker/src/commands/qnamaker/query.ts 41.93% <0.00%> (-8.07%) ⬇️
...ispatcher/src/data/AppEntityAnnotatedCorpusData.ts 92.00% <0.00%> (-8.00%) ⬇️
... and 81 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10e144c...b6165d7. Read the comment docs.

@xhr0804
Copy link
Contributor Author

xhr0804 commented Aug 6, 2020

@vishwacsena @scheyal Could you please review the spec

@munozemilio munozemilio changed the base branch from master to main August 20, 2020 20:24
Copy link
Contributor

@scheyal scheyal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spec for the backlog. We should have a QnAMaker test CLI.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants