Connection count #94
Merged
Connection count #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
May 16, 2024 20:10
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes significant changes to the
scripts/two-machine-perf.ps1file. The changes involve the addition of a new parameter,ConcurrentConnections, and the restructuring of command options for better code organization and reusability.Here are the most important changes:
Parameter Addition:
scripts/two-machine-perf.ps1: Added a new optional parameterConcurrentConnectionswith a default value of 32. Additionally, a line was added to output the test configuration parameters, including the newConcurrentConnectionsparameter.Command Options Restructuring:
scripts/two-machine-perf.ps1: Introduced variables$CommonOptionsand$ClientOptionsto hold the common and client-specific command options respectively. This change simplifies the command options and makes the code more maintainable.scripts/two-machine-perf.ps1: Modified theInvoke-Commandscript block parameters to use$CommonOptionsinstead of$Duration. This change allows the reuse of common command options in multiple places. [1] [2]