Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Developer Documentation #189

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

Tanish-Ranjan
Copy link
Contributor

This is the start for developer documentation covering my contributions to the repository. #185

@Tanish-Ranjan Tanish-Ranjan marked this pull request as ready for review August 29, 2024 08:26
docs/README.md Outdated Show resolved Hide resolved
docs/README.md Outdated Show resolved Hide resolved
docs/android/README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@jdneo jdneo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

One comment is that please revert the changes that adding the line breaks, which are unnecessary.

Thank you!

@jdneo jdneo added the documentation Improvements or additions to documentation label Aug 30, 2024
Copy link

@oleg-nenashev oleg-nenashev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for landing it. I might add some suggestions incrementally, but I can easily read the docus and I find them helpful for end users. Good job!

@Tanish-Ranjan
Copy link
Contributor Author

Thanks! I will improve it overtime.

@Tanish-Ranjan
Copy link
Contributor Author

@jdneo We have android support PRs merged on both Gradle Build Server and Gradle for Java extension. There should be no blockers for this at the moment.

@Tanish-Ranjan Tanish-Ranjan force-pushed the feat/developer-documentation branch from 04e7669 to f9c0987 Compare September 6, 2024 09:00
@jdneo jdneo added this to the 0.4.0 milestone Sep 9, 2024
@jdneo jdneo merged commit 34b8c05 into microsoft:develop Sep 9, 2024
4 checks passed
@jdneo
Copy link
Member

jdneo commented Sep 9, 2024

@Tanish-Ranjan Merged. Thanks for the contribution.

@Tanish-Ranjan Tanish-Ranjan deleted the feat/developer-documentation branch September 9, 2024 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants