refactor: Refactoring the model related code. #85
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jdneo
commented
Sep 18, 2023
jdneo
commented
- Move the DefaultXXX to the model sub-project. Since the implementation of the model can be used for both plugin and server.
- Make all the interfaces in the model extend Serializable. Then no need for the implementation classes to declare Serializable.
- Add Copy constructor for the model classes. This is because the model result returned from Gradle Tooling API is not the original type but a wrapped one. This causes some issue when calling the 'equals()' method.
- Move the DefaultXXX to the model sub-project. Since the implementation of the model can be used for both plugin and server. - Make all the interfaces in the model extend Serializable. Then no need for the implementation classes to declare Serializable. - Add Copy constructor for the model classes. This is because the model result returned from Gradle Tooling API is not the original type but a wrapped one. This causes some issue when calling the 'equals()' method. Signed-off-by: Sheng Chen <sheche@microsoft.com>
jdneo
added
the
engineering
testforstephen
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.