Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projected members do not have projected parents and projected source properties. #1069

Closed
nguerrera opened this issue Sep 22, 2022 · 1 comment · Fixed by #1115
Closed

Projected members do not have projected parents and projected source properties. #1069

nguerrera opened this issue Sep 22, 2022 · 1 comment · Fixed by #1115
Assignees
Labels
bug Something isn't working

Comments

@nguerrera
Copy link
Contributor

nguerrera commented Sep 22, 2022

It appears that all of the following can have their invariants broken by projection.

Parents

  • EnumMember.enum
  • ModelProperty.model
  • Operation.interface
  • UnionVariant.union

SourceProperty

  • ModelProperty.sourceProperty

When fixing this, you should be able to make the simplification described in isImplicitPathParam in parameters.ts:

https://github.com/microsoft/cadl/blob/aee5025f5de10bd9b866e7437a806eb1431aeba4/packages/rest/src/http/parameters.ts#L60-L62

and revert what I think was another workaround for this in #819:

https://github.com/microsoft/cadl/pull/819/files#diff-96a2a8924df0be7c47132dbeb88359876840b1300e4c985e5865fe709dee764b

@ghost ghost added the Needs Triage label Sep 22, 2022
@markcowl markcowl added this to the [2022] October milestone Sep 23, 2022
@markcowl
Copy link
Contributor

pri: 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
3 participants