Reparent members in clone type #1067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguerrera
requested review from
bterlson,
daviwil,
markcowl,
allenjzhang and
timotheeguerin
as code owners
|
Ugh this doesn't quite fix it, it's part of the solution. Converting to draft until I get to the bottom of it. |
|
You can try these changes at https://cadlplayground.z22.web.core.windows.net/prs/1067/ Check the website changes at https://cadlwebsite.z1.web.core.windows.net/prs/1067/ |
|
Seems we're also not reparenting during projection, see also #819 (comment) |
|
Real issue is #1069 This is good to fix too but not the problem I was immediately facing. |
|
Marking ready for review. It's no longer urgent for me, but it does fix a bug. |
timotheeguerin
approved these changes
Sep 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caused an issue with the merge with implicit path params into metadata. I ended up needing a param.model === operation.parameters to check that a param is top-level in order to be implicit and it started failing due to cloneType not resetting parent to clone.