Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some content in Currency Converter not right-aligned properly in RtL #409

Closed
grochocki opened this issue Mar 29, 2019 · 2 comments · Fixed by #410
Closed

Some content in Currency Converter not right-aligned properly in RtL #409

grochocki opened this issue Mar 29, 2019 · 2 comments · Fixed by #410
Labels
Area: World-Readiness fixed Pri: 3

Comments

@grochocki
Copy link
Contributor

Describe the bug
While in an RtL language, Currency Converter refresh content is not right-aligned.

Steps To Reproduce

  1. Switch to RtL language
  2. Navigate to Currency Converter page
  3. Observe that the refresh rates content is not right-aligned with currencies.

Expected behavior
All content should be right-aligned along the same vertical.

Screenshots
image

Device and Application Information (please complete the following information):

  • OS Build: 10.0.17763.0
  • Architecture: X64
  • Application Version: 10.1903.3.0
@grochocki grochocki added Bug Issue is a bug Pri: 3 triage approved Issue has been approved by Calculator team member Area: World-Readiness labels Mar 29, 2019
@grochocki grochocki mentioned this issue Mar 29, 2019
Closed
@rudyhuyn
Copy link
Contributor

rudyhuyn commented Mar 29, 2019 •
edited
Loading

Working on it!

@rudyhuyn rudyhuyn mentioned this issue Mar 29, 2019
Merged
@MicrosoftIssueBot
Copy link
Collaborator

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

danbelcher-MSFT pushed a commit that referenced this issue Apr 20, 2019
@rudyhuyn
Fix UI issues with UnitConverter in RtL (#410)
0d31d5a 
Fix #409 - Some content in Currency Converter not right-aligned properly in RtL
Fix #59 Currency symbol precedence is opposite of system setting in RTL languages

Description of the changes:
Add a property FlowDirectionHorizontalAlignment in UnitConverter to align some controls to the right (without modifying the FlowDirection of their parent items)
Force FlowDirection of Value1Container and Value2Container to LeftToRight (but align panels to the right)

How changes were validated:
Tested with LtR and RtL languages and with currency symbols on the left and on the right.
@MicrosoftIssueBot MicrosoftIssueBot added fixed and removed triage approved Issue has been approved by Calculator team member labels Apr 20, 2019
EriWong pushed a commit to EriWong/calculator that referenced this issue Jun 5, 2019
@rudyhuyn @EriWong
Fix UI issues with UnitConverter in RtL (microsoft#410)
754e5f4 
Fix microsoft#409 - Some content in Currency Converter not right-aligned properly in RtL
Fix microsoft#59 Currency symbol precedence is opposite of system setting in RTL languages

Description of the changes:
Add a property FlowDirectionHorizontalAlignment in UnitConverter to align some controls to the right (without modifying the FlowDirection of their parent items)
Force FlowDirection of Value1Container and Value2Container to LeftToRight (but align panels to the right)

How changes were validated:
Tested with LtR and RtL languages and with currency symbols on the left and on the right.
@MicrosoftIssueBot MicrosoftIssueBot removed the Bug Issue is a bug label Mar 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area: World-Readiness fixed Pri: 3
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #409 and #59 - UI issues with UnitConverter in RtL
3 participants
@rudyhuyn @grochocki @MicrosoftIssueBot