Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In High-Contrast mode, the Title Bar should change color when the window is inactive #441

Closed
rudyhuyn opened this issue Apr 6, 2019 · 7 comments
Closed

In High-Contrast mode, the Title Bar should change color when the window is inactive #441

rudyhuyn opened this issue Apr 6, 2019 · 7 comments
Labels
Area: Accessibility Issues with keyboard interactions, screen readers, contrast, font size, and other accessibilty areas fixed Pri: 2

Comments

@rudyhuyn
Copy link
Contributor

rudyhuyn commented Apr 6, 2019

Describe the bug
As indicated here: https://docs.microsoft.com/en-us/windows/uwp/design/shell/title-bar

Do make is obvious when your window is active or inactive. At a minimum, change the color of the text, icons, and buttons in your title bar.

This is even more true when High-Contrast is activated to improve accessibility.

The Calculator currently uses the same color when the window is active and inactive.

Steps To Reproduce

  • Activate High-Contrast
  • Launch the Calculator
  • Switch between applications
    --> the Title bar color doesn't change.

Expected behavior

  • the title bar should change color

Screenshots

image

image

Device and Application Information (please complete the following information):

  • OS Build: 10.0.18362.0
  • Architecture: X64
  • Application Version: 10.1812.10048.0
@rudyhuyn
Copy link
Contributor Author

rudyhuyn commented Apr 6, 2019

I just noticed the titlebar has also an issue with padding on the right:

image

@rudyhuyn rudyhuyn mentioned this issue Apr 6, 2019
Merged
@grochocki grochocki added Area: Accessibility Issues with keyboard interactions, screen readers, contrast, font size, and other accessibilty areas Bug Issue is a bug Pri: 2 triage approved Issue has been approved by Calculator team member labels Apr 7, 2019
@grochocki
Copy link
Contributor

Good catch. Outside of HC, we have acrylic/no acrylic, but we should definitely handle HC case as well.

@rudyhuyn
Copy link
Contributor Author

rudyhuyn commented Apr 7, 2019 •
edited
Loading

Good catch. Outside of HC, we have acrylic/no acrylic, but we should definitely handle HC case as well.

The PR I sent only modify the UI when in HC, but we should probably also modify the color of the title when Acrylic is disabled (Battery Saver, Transparency Effects disabled by users in Settings > Personalization > Colors, ... ), I can include that in my current PR if you are ok.

Impossible to see that the Calculator doesn't have the focus:
image

@grochocki
Copy link
Contributor

we should probably also modify the color of the title when Acrylic is disabled... I can include that in my current PR if you are ok.

Good point. Yes, we can cover that as part of this PR.

@MicrosoftIssueBot
Copy link
Collaborator

This is your friendly Microsoft Issue Bot. I've seen this issue come in and have gone to tell a human about it.

@rudyhuyn
Copy link
Contributor Author

rudyhuyn commented Apr 8, 2019

@grochocki: ok, I will try to update the PR on the following days (It's our annual Hackathon this week)

danbelcher-MSFT pushed a commit that referenced this issue Apr 20, 2019
@rudyhuyn
Simplify title bar (#442)
bd04c92 
Fixes #407 (partially) and #441

Description of the changes:
Remove TitleBarHelper and all <Border x:Name="CustomTitleBar" />
Let the system defines the draggable region
Centralize all events and functions associated to the title bar in a single control TitleBar instead of code splitted between MainPage/TitleBar/HistoryList/Memory.
Use the standard title bar when high contrast is activated instead of the custom one.
Modify the color of the title when the window doesn't have focus
Fix the right padding of the title bar with high contrast

How changes were validated:
Manually tested with LtR and RtL languages
Manually tested with high contrast
Tested when History and Memory flyout are opened
@grochocki
Copy link
Contributor

It appears this was fixed as part of #442, but was not caught by automation.

@MicrosoftIssueBot MicrosoftIssueBot removed the triage approved Issue has been approved by Calculator team member label Apr 30, 2019
EriWong pushed a commit to EriWong/calculator that referenced this issue Jun 5, 2019
@rudyhuyn @EriWong
Simplify title bar (microsoft#442)
64bb45d 
Fixes microsoft#407 (partially) and microsoft#441

Description of the changes:
Remove TitleBarHelper and all <Border x:Name="CustomTitleBar" />
Let the system defines the draggable region
Centralize all events and functions associated to the title bar in a single control TitleBar instead of code splitted between MainPage/TitleBar/HistoryList/Memory.
Use the standard title bar when high contrast is activated instead of the custom one.
Modify the color of the title when the window doesn't have focus
Fix the right padding of the title bar with high contrast

How changes were validated:
Manually tested with LtR and RtL languages
Manually tested with high contrast
Tested when History and Memory flyout are opened
@MicrosoftIssueBot MicrosoftIssueBot removed the Bug Issue is a bug label Mar 30, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Area: Accessibility Issues with keyboard interactions, screen readers, contrast, font size, and other accessibilty areas fixed Pri: 2
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rudyhuyn @grochocki @MicrosoftIssueBot