Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the "about equal to" for Data Converter #2170

Merged
merged 2 commits into from
Jul 1, 2024

Conversation

zxxzxxzxhk
Copy link
Contributor

Fixes # Na

Description of the changes:

As DVD size is 4700 megabytes. However, current converter's "about equal to" is only showing 0.93 DVDs when 4700 megabytes is entered.
image

Therefore, { ViewMode::Data, UnitConverterUnits::Data_DVD, 5046.586573 } is revised to { ViewMode::Data, UnitConverterUnits::Data_DVD, 4700 }, under UnitConverterDataLoader.cpp
image

How changes were validated:

Manual testing was done. 1 DVDs is shown when 4700 megabytes was entered.

@tian-lt
Copy link
Contributor

tian-lt commented Jun 28, 2024

Thanks @zxxzxxzxhk for sending this PR. It looks good to me.
BTW, the capacity number of CD also seems a bit wired. 700 Megabytes is a common size for CD-R. Could you help take a look and update it as well in this PR?
Thanks again.

@zxxzxxzxhk
Copy link
Contributor Author

Thanks @zxxzxxzxhk for sending this PR. It looks good to me. BTW, the capacity number of CD also seems a bit wired. 700 Megabytes is a common size for CD-R. Could you help take a look and update it as well in this PR? Thanks again.

Done!

@tian-lt tian-lt merged commit 41a3fa0 into microsoft:main Jul 1, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants